search

ethereum / aleth

Aleth – Ethereum C++ client, tools and libraries
GNU General Public License v3.0
3.97k stars 2.17k forks source link

JSON-RPC: Use Unix Socket Server from libjsonrpccpp #4565

Open chfast opened 7 years ago

chfast commented 7 years ago

The libjsonrpccpp library have implementation of Unix Socket Server for JSON-RPC. Let's use it and remove our internal implementation.

Our implementation (to be replaced): https://github.com/ethereum/cpp-ethereum/blob/develop/libweb3jsonrpc/UnixSocketServer.h

The Unix Socket server from libjson-rpc-cpp: https://github.com/cinemast/libjson-rpc-cpp/blob/master/src/jsonrpccpp/server/connectors/unixdomainsocketserver.h

Please first find out if we have any tests that depends on Unix Socket RPC transport.

YaroslavZhurba commented 6 years ago

I'll do it!

chfast commented 6 years ago

Ok, great! Please report your progress if possible.

chfast commented 6 years ago

Any progress on this?

YaroslavZhurba commented 6 years ago

May I answer in the end of the week?

22 нояб. 2017 г., в 20:20, Paweł Bylica notifications@github.com написал(а):

Any progress on this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

YaroslavZhurba commented 6 years ago

I have some problems with building projects. I instaledl Cmake (but it doesn't work), may be you can help me? cmake .. CMake Error: The source directory "/Users/zhurba_ys/hello" does not appear to contain CMakeLists.txt. Specify --help for usage, or press the help button on the CMake GUI.

chfast commented 6 years ago

Please see this branch: https://github.com/ethereum/cpp-ethereum/pull/4688.

vaind commented 6 years ago

What's the status on this issue? Need any help? I've implemented JSON-RPC client & server before so if there are any problems I may be able to help.

chfast commented 6 years ago

I tried it, and it totally does not work. See https://github.com/ethereum/cpp-ethereum/pull/4688.