ethereum / aleth

Aleth – Ethereum C++ client, tools and libraries
GNU General Public License v3.0
3.96k stars 2.18k forks source link

aleth + retesteth issue 1 #5886

Open winsvega opened 4 years ago

winsvega commented 4 years ago
Request: {"jsonrpc":"2.0","method":"eth_getTransactionCount","params":["0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b", "0x1"],"id":8}
Reply: {"id":8,"jsonrpc":"2.0","result":"10"}

aleth response with string. geth response with int.

Request: {"jsonrpc":"2.0","method":"eth_getTransactionCount","params":["0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b", "0x1"],"id":8}
Reply: {"jsonrpc":"2.0","id":8,"result":10}
winsvega commented 4 years ago

retesteth support: https://github.com/ethereum/retesteth/pull/74/commits/453e1b7f82b5b399b7b6d8987e41657efebbe70c

winsvega commented 4 years ago

I would say we need RPC protocol strikness and unification. @holiman