search

ethereum / asyncio-run-in-process

A simple asyncio friendly replacement for multiprocessing to run coroutines in a separate process.
MIT License
13 stars 9 forks source link

A big ugly hack to make one of trinity's test pass again #14

Closed gsalgado closed 4 years ago

gsalgado commented 4 years ago

Something like this will be needed to keep that trinity test passing if we want to get rid of the code in AsyncioIsolatedComponent that duplicates something we already have in open_in_process()

pipermerriam commented 4 years ago

As convoluted and nasty as this is, I could be ok with it. Any chance there's a test we could write that covers this new behavior?

gsalgado commented 4 years ago

Any chance there's a test we could write that covers this new behavior?

I spent almost a day trying to reproduce it in a simpler test, without any luck

gsalgado commented 4 years ago

I've refactored things a bit to make it slightly less ugly.

gsalgado commented 4 years ago

No longer needed