New APIs to run trio-based code in the subprocess

ethereum / asyncio-run-in-process

A simple asyncio friendly replacement for multiprocessing to run coroutines in a separate process.

MIT License

13 stars 9 forks source link

New APIs to run trio-based code in the subprocess #20

Closed gsalgado closed 4 years ago

gsalgado commented 4 years ago

I don't believe that the trio version of this handles keyboard interrupts in the same way since I don't see any code that handles injecting the KeyboardInterrupt into the running coroutine in the child.

trio takes care of that for us: https://trio.readthedocs.io/en/stable/reference-core.html#trio.run

And one of our tests (test_open_proc_SIGINT_can_be_handled) ensure that it works for both the asyncio/trio APIs

gsalgado commented 4 years ago

@pipermerriam I've addressed all the points you made. if you're happy with it I'll write docs