ethereum / beacon-APIs

Collection of RESTful APIs provided by Ethereum Beacon nodes
https://ethereum.github.io/beacon-APIs/
Creative Commons Zero v1.0 Universal
328 stars 167 forks source link

Removed default builder boost #438

Open fredriksvantes opened 5 months ago

fredriksvantes commented 5 months ago

Removed "default" boost wording where the default value should be a fixed to 100 on clients as this has been changed to 90 on multiple clients.

mcdee commented 5 months ago

We can't just remove the default, it's already part of the released spec and it's possible that validator clients are sending in requests without this value and expecting it to be 100.

Given that at this point there are client releases that have altered this value I think the best bet would be to state that if the parameter is not supplied then it defaults to whatever value is configured in the beacon node. Although that doesn't adhere to the spec as-is, and so is still a spec change, I think it is the closest that we will get when taking reality into account.