ethereum / beacon-APIs

Collection of RESTful APIs provided by Ethereum Beacon nodes
https://ethereum.github.io/beacon-APIs/
Creative Commons Zero v1.0 Universal
335 stars 169 forks source link

getBlobSidecars is missing metadata fields in response #439

Closed nflaig closed 6 months ago

nflaig commented 6 months ago

It looks like getBlobSidecars API does not include execution_optimistic and finalized fields https://github.com/ethereum/beacon-APIs/blob/fc89ec5c5f0904a0057fc543f0eb4ddaa480f04e/apis/beacon/blob_sidecars/blob_sidecars.yaml#L34-L37

Whereas the getBlockV2 does and even includes version which we might wanna add for blobs as well

https://github.com/ethereum/beacon-APIs/blob/fc89ec5c5f0904a0057fc543f0eb4ddaa480f04e/apis/beacon/blocks/block.v2.yaml#L25

I don't see any discussion on this in https://github.com/ethereum/beacon-APIs/pull/286, so I guess it was just missed?