search

ethereum / beacon-APIs

Collection of RESTful APIs provided by Ethereum Beacon nodes
https://ethereum.github.io/beacon-APIs/
Creative Commons Zero v1.0 Universal
335 stars 169 forks source link

Validator identities endpoint. #452

Closed mcdee closed 1 month ago

mcdee commented 4 months ago

In support of #449.

rolfyone commented 4 months ago

This looks good. Will cross-post and seek more opinions.

rkapka commented 4 months ago

I support this. Our validator client currently needs to grab the full validator to get the index

nflaig commented 4 months ago

I support this. Our validator client currently needs to grab the full validator to get the index

Curious, do you track the validator status on the VC side? This has a lot of benefits, e.g. not querying duties for exited validators, not registering to builder etc. but it would still require to query the full validator object if we don't include all information in this API to recalculate the status, or include the status itself here, preferably in a format that can be ssz-serialized.

rkapka commented 4 months ago

Curious, do you track the validator status on the VC side?

No, we don't. I agree it would allow for certain optimizations, but I am not sure if it's worth the extra complexity.

rolfyone commented 4 months ago

I think i prefer the idea that this is a simple index lookup that would allow us to continue to use it in a post index being unique world, and for the rest of the data you have the indices you could look up further info...

rolfyone commented 4 months ago

we can definitely add this to changes table though...