search

ethereum / beacon-APIs

Collection of RESTful APIs provided by Ethereum Beacon nodes
https://ethereum.github.io/beacon-APIs/
Creative Commons Zero v1.0 Universal
335 stars 169 forks source link

Remove deprecated produce block apis #466

Open nflaig opened 2 months ago

nflaig commented 2 months ago

This removes previously deprecated produce blocks apis

Those were replaced / consolidated by GET /eth/v3/validator/blocks/{slot} during Capella and part of spec release for Deneb.

Implementations should be able to safely remove the apis after Electra fork.

rolfyone commented 2 months ago

I do agree with the sentiment, but we probably want to hold off merging this until electra or they'll no longer be listed...

I know at least teku is still calling v2 in several deneb releases, so if other clients are not publishing those endpoints that could be a potential problem.

I guess equally if we said 2.5.0 is what is expected in deneb, this would be able to be merged... We don't really have a great way of articulating that maybe?

nflaig commented 2 months ago

Removal of apis is a bit tricky and I would generally recommend implementations only remove those in their next release after the Electra fork as this is the only way to ensure everyone has updated their clients and no longer use v2.

As per merging this, we can hold off on it but I would say it depends on when we wanna cut the next stable release. If it is not before Electra it might be fine to merge it already, the apis being removed from dev explorer shouldn't be an issue?

In case of Lodestar, since we run api spec tests, we can only remove them after the spec has removed them, so it would be fine to wait until we cut the Electra release.

Maybe we cut a 2.6.0 release soon to get more visibility on new apis and before Electra we cut a 3.0.0 and remove the apis, which we might wanna consider as a breaking change.

tersec commented 1 month ago

In favor of removing.

rolfyone commented 1 month ago

In favor of removing.

we can remove these, but not until after electra, so in an f* fork. They've been marked deprecated i believe for this release, but we can't just delete them until we've done the electra beacon-api release tag etc.