search

ethereum / beacon_chain

MIT License
211 stars 65 forks source link

Tests for Simple Serialization (SSZ) #102

Closed p-mc2 closed 6 years ago

p-mc2 commented 6 years ago

Basic initial PR for creating individual tests with specific test location for SSZ. Covers the basics of #100 I intend to build further tests into these going forward.

Should test_serialization.py be removed now? It still covers the ActiveState and PartialCrossLinkRecord cases. Thanks.

hwwhww commented 6 years ago

@Poseyy Aww, sorry I just updated the ticket #100 description before I saw your PR! I think yes, tests/utils/test_serialization.py can be removed. And would you like to take a look at how can we refactor SSZ in this PR or other PRs? (I listed something like (i) Error handling (ii) Serializable class)

p-mc2 commented 6 years ago

@hwwhww yep, no problem! I'll make the necessary changes asap. Thanks!

p-mc2 commented 6 years ago

@hwwhww Mind if I do that in another PR and we merge this one (if it's ready)? Might be a little delayed on the changes depending on how much time I can manage tomorrow. Thanks.

(Can leave this open and can work through this PR if that's preferred)