search

ethereum / beacon_chain

MIT License
209 stars 65 forks source link

Change Validator.balance to type `int128` #105

Closed djrtwo closed 5 years ago

djrtwo commented 5 years ago

Issue

v2.1 spec changes Validator.balance to type int128 to allow for full wei precision. This is in-line with ewasm's intentions to use int128 for wei/ether.

Proposed Implementation

johnsBeharry commented 5 years ago

hey @djrtwo, I committed the change – but are you expecting anything other than this field type modified? 😅

I'm still getting acquainted with the project – if this is the expected scope I'll go ahead open up a PR.

djrtwo commented 5 years ago

The only other thing you would need to do is make sure the test-suite still runs as expected. I don't think this change will affect anything else currently in the repo