search

ethereum / beacon_chain

MIT License
211 stars 65 forks source link

[WIP]explicit support for uint vs int in simple serialize #114

Closed p-mc2 closed 6 years ago

p-mc2 commented 6 years ago

As has been discussed, it's probably worth our time to explicitly support uint vs int in simple serialize to avoid confusion. Thanks.

p-mc2 commented 6 years ago

Seems like my implementation is the best way to handle this in ssz but there are a ton of spots where there's overflow because things that should be unsigned are named 'int64' for example. Should I go through and edit all of these ints to uints or am I misunderstanding something? Thanks.

djrtwo commented 6 years ago

I think if we move forward with uint support (which I think is likely), then all of the int's in the current spec are actually uints. So you can go ahead and change them all.

djrtwo commented 6 years ago

closing this one