ethereum / beacon_chain

MIT License

209 stars 65 forks source link

Make data types explicit in attestation sig message #116

Closed djrtwo closed 5 years ago

djrtwo commented 5 years ago

Issue

Some of the types are not explicit and thus incorrect in the following signature message construction

https://github.com/ethereum/beacon_chain/blob/be4bff59da2bb5440dbe3ecd3338b61749c37ae0/beacon_chain/state/state_transition.py#L117-L123

Proposed Implementation

Make the int sizes explicit according to their size stated in ssz state.

(we might move to using SSZ to handle this serialization. discussion here https://github.com/ethereum/eth2.0-specs/issues/5)