ethereum / beacon_chain

MIT License
211 stars 65 forks source link

V2.1 update #50

Closed djrtwo closed 6 years ago

djrtwo commented 6 years ago

Ready for review

There are a few bugs in the spec, noted here. This codebase reflects the fixes to these bugs so you'll see some disparities between the codebase and the spec. I expect Vitalik to fix these in a couple of days.

TODO:

MISSING (saving for another PR)

djrtwo commented 6 years ago

Most PR changes addressed except for a couple of questions above. Thanks @hwwhww !!

djrtwo commented 6 years ago

Also, there are some updates to the spec from V already that aren't reflected in here...

djrtwo commented 6 years ago

I think it would be clear if most “height”s in the spec are replaced with “slot”s, or "index"s if it's about the ith slot of this cycle. IMO It’s confusing because we usually use “heights” as the block serial numbers. Does it makes sense?

Hm.. you are right. I'll try to clean it up now

djrtwo commented 6 years ago

@hwwhww I'm thinking about leaving the following for a future PR. I'm pretty afk this week and don't want to hold you or anyone else up on collaborating

hwwhww commented 6 years ago

@djrtwo no problem! And I can add more unit tests in the following PR.