Add and use `get_indices_for_slot` and `get_block_hash` - Githubissues

ethereum / beacon_chain

MIT License

211 stars 65 forks source link

Add and use `get_indices_for_slot` and `get_block_hash` #62

Closed hwwhww closed 6 years ago

hwwhww commented 6 years ago

What was wrong?

Fixes #59

How was it fixed?

Rename indices_for_heights to indices_for_slots
Added get_indices_for_slot and get_block_hash helper functions.
Modified get_signed_parent_hashes() and get_attestation_indices to use those functions.

I think if we use the old get_signed_parent_hashes() + add some boundary cases checks, it would be faster and efficient than the new one.

TODO: Add more tests and refactor.