Closed hwwhww closed 5 years ago
Looks good to me. We could at this point set attestation.justified_slot
in mock_make_attestations
but without chain object, we would still not be setting Attestation.justified_block_hash
.
@djrtwo thanks! I added:
justified_slot=crystallized_state.last_justified_slot,
# TODO: it's a stub for now and will be changed to the correct block hash
justified_block_hash=ZERO_HASH32,
Will go back and set the correct block hash later.
74, except for the validation. We need a
Chain
object to check the canonical chain blocks. I think we can open another ticker for justified slot validation part.