Allow building on stable Rust + some warning fixes

ethereum / blake2b-py

Blake2b hashing in Rust with Python bindings.

MIT License

7 stars 17 forks source link

Allow building on stable Rust + some warning fixes #9

Closed fjarri closed 1 year ago

fjarri commented 2 years ago

Our company uses blake2b as one of the dependencies, and it is a common issue when different people cannot build the library from source because it requires nightly Rust. This PR attempts to fix that.

bump PyO3 to 0.15 (0.8 requires nightly Rust)
only enable feature(test) when testing, so building can be done on stable
fix a maturin warning (no explicit version in pyproject.toml)
fix a Rust warning (deprecated iterators)

fjarri commented 2 years ago

Ah, sorry, just noticed PR #5. I guess the only new thing in this PR is gating the test feature.

vquelque commented 2 years ago

Any update here? This library is used in a bunch of tools and it would be nice to be able to compile it with stable rust !

cburgdorf commented 2 years ago

Sorry, I missed this. Could you do me a favor and rebase this on latest master. I just enabled CI runs for PRs and I would just like to see all tests passing before we can merge this.

kclowes commented 1 year ago

@fjarri I dropped Python 3.6 in #11 so once that's in, I'll get this one in.