search

ethereum / c-kzg-4844

A minimal implementation of the Polynomial Commitments API for EIP-4844 and EIP-7594, written in C.
Apache License 2.0
118 stars 109 forks source link

Update java bindings to use runtime field count #364

Closed jtraglia closed 1 year ago

jtraglia commented 1 year ago

This PR updates the Java bindings to work with runtime field counts.

jtraglia commented 1 year ago

@StefanBratanov do we need to expose a getBytesPerBlob() method?

StefanBratanov commented 1 year ago

@StefanBratanov do we need to expose a getBytesPerBlob() method?

We already do it in CKZG4844JNI right? Or you mean have it as a native method?

StefanBratanov commented 1 year ago

Can change actually the javadoc of getFieldElementsPerBlob() as well since it is not correct.

jtraglia commented 1 year ago

@StefanBratanov do we need to expose a getBytesPerBlob() method?

We already do it in CKZG4844JNI right? Or you mean have it as a native method?

Ah that's right. I forgot it was in CKZG4844JNI. It doesn't need to be a native method.

jtraglia commented 1 year ago

Can change actually the javadoc of getFieldElementsPerBlob() as well since it is not correct.

Fixed in 072cb97. Happy to make changes if it doesn't read well.

StefanBratanov commented 1 year ago

Can change actually the javadoc of getFieldElementsPerBlob() as well since it is not correct.

Fixed in 072cb97. Happy to make changes if it doesn't read well.

Looks good. Thanks. Happy to merge.