search

ethereum / c-kzg-4844

A minimal implementation of the Polynomial Commitments API for EIP-4844 and EIP-7594, written in C.
Apache License 2.0
112 stars 105 forks source link

Remove unnecessary tests in the bindings #477

Closed jtraglia closed 1 month ago

jtraglia commented 1 month ago

Also controversial, but there are a bunch of "old" tests in the bindings that existed before there were reference tests. So each of the bindings kind of did their own thing, then added the reference tests. So they are testing the same thing, but are considerably more complex. We haven't added non-reference tests for EIP-7594 to each of the bindings. This is not something that I would like to do either.

asn-d6 commented 1 month ago

I assume this has been a maintainance burden everytime we change the API right? If not, I would just keep them around. If yes, I agree, let's remove them and rely on the test vectors.

jtraglia commented 1 month ago

It's not really a maintenance burden in that sense. Closing.