search

ethereum / c-kzg-4844

A minimal implementation of the Polynomial Commitments API for EIP-4844 and EIP-7594, written in C.
Apache License 2.0
112 stars 105 forks source link

Upgrade blst to v0.3.13 #485

Closed jtraglia closed 1 month ago

jtraglia commented 1 month ago

blst made a new release a few weeks ago:

https://github.com/supranational/blst/releases/tag/v0.3.13

This also updates the version in the Go & Rust bindings.

jtraglia commented 1 month ago

I'll fix the windows build issues tomorrow morning.

jtraglia commented 1 month ago

So there's a problem with the build.bat file used to build blst on Windows. On this line, %PATH% is expanded twice (once in the cmd & once in the comment) and will grow past the 8192-character limit if PATH is greater than 4096 characters. When using msvc-dev-cmd and several other actions (including calling VsDevCmd.bat myself) PATH will be greater than that 4096-character limit. We could modify PATH to only include the paths we need, but that's a lot of work and would be especially difficult in the Python release script, which we cannot modify PATH. I've talked with Andy (dot-asm) about this and he is aware of the issue. I expect the next release will include a fix for this. Therefore, I suggest we skip this release (it's pretty minor) and wait for the next one.