search

ethereum / cbc-casper

GNU Affero General Public License v3.0
229 stars 44 forks source link

[BIG] hash-linking/network update/cleanup #106

Closed naterush closed 6 years ago

naterush commented 7 years ago

Starting work on hash-linking messages rather than including all messages in a justification! Things are very messy as of now, but it's a good start.

To see this working, run make run-full - and you will see this works! If you run rand, you may get lucky and see a few validators build on top of other blocks. Otherwise, they will not, as they do not receive all the relevant messages from each other.

In general, this PR will not work until there are some dramatic fixes to the network. Going to start work on another PR to address this as well (and get all messages propagating to all validators in every case, just as a first attempt).

NOTE: This PR should likely be merged not-into-master. Or at least we should have a release branch.

naterush commented 7 years ago

Tests are currently passing, but many need to be cleaned up dramatically. Also, tests need to be added for the newly added hash linking (the tests currently passing are just the old tests; nothing new has been added yet).

I'm going to leave the rework the testing language (though badly needed) to another PR!

djrtwo commented 7 years ago

cleanup crew coming through!

djrtwo commented 7 years ago

check out my recent commits. not married to any of it, but just trying to manage the complexity and readability

naterush commented 6 years ago

Looks good to merge, pending final change above :)