ethereum / cbc-casper

GNU Affero General Public License v3.0

229 stars 44 forks source link

OrderView should inherit from some standard view #142

Closed djrtwo closed 6 years ago

djrtwo commented 7 years ago

Issue

OrderView is pretty much the same as BinaryView and IntegerView. These guys should all inherit from some common view like ValueView.

Proposed Implementation

Ensure OrderView is not repeating a bunch of code
Maybe move guts of IntegerView to something like ValueView
should use initial_message from OrderProtocol

naterush commented 6 years ago

Hmm. The gains here are relatively minor (and the codebase might actually suffer in terms of readability - given how much inheritance we got going on now).

Closing for now.