search

ethereum / cbc-casper

GNU Affero General Public License v3.0
229 stars 44 forks source link

Feat/forkchoice reduction #149

Open naterush opened 6 years ago

naterush commented 6 years ago

This is not actually meant to be merged (it was a branch off of the old develop). Just a PoC research type deal. This implements the efficient fork choice functions.

I'm running into this weird, random bug where I can't set the color of the nodes. In the plot tool, I run into the error:

ax.collections[0].set_edgecolor("black")
IndexError: list index out of range

When I print ax.collections, it's an empty list. Not sure why this is the case (displaying worked until I made the changes to view). Is it possible there is a dependancy issue? Not sure.

I can't figure out why changing the view in the way I did would change this would have any effect at all, and have been thrashing for a bit w/ it so thought it would be good to get another pair of eyes on it!

naterush commented 6 years ago

@djrtwo if you get a chance, I'd love another set of eyes on this bug. It's very weird and I can't figure out why it would possibly happen :D

naterush commented 6 years ago

The above bug is fixed! The fork choice is unfortunately not the same, though. Going to keep debugging + updating the spec for the algo as necessary.