ethereum / clrfund

Eth2 CLR project built on clr.fund
https://eth2clrfund.netlify.app/
GNU General Public License v3.0
29 stars 15 forks source link

Hide MetaMask as option on mobile? #269

Closed samajammin closed 2 years ago

samajammin commented 2 years ago

Should we hide MetaMask as an option on mobile?

clr fund - clr fund 2021-08-17 at 3 09 58 PM

Perhaps pop them straight into WalletConnect?

clr fund - clr fund 2021-08-17 at 3 10 12 PM

Curious what other apps do / what best practices are here 🤔

corwintines commented 2 years ago

@samajammin if they are using metamask on mobile would we just assume connecting to metamask? I know when I use these dapps in metamask, the apps seem to assume im going to connect with metamask and just connect that. Maybe we check if they are connecting through metamask or another browser, and handle that accordingly when on mobile?

wackerow commented 2 years ago

Yeah, agree that the subset of people who load this directly from MetaMask browser would not need the WalletConnect option, even though they are on mobile.

samajammin commented 2 years ago

@samajammin if they are using metamask on mobile would we just assume connecting to metamask?

Ah, I suppose I just assumed you couldn't use MetaMask on mobile (since it's a browser extension). Seems that's not the case?

samajammin commented 2 years ago

Just confirmed, I can use MetaMask via MetaMask mobile app & the in-app browser. Gonna close this out.