search

ethereum / clrfund

Eth2 CLR project built on clr.fund
https://eth2clrfund.netlify.app/
GNU General Public License v3.0
32 stars 17 forks source link

Consolidate network token logic? #492

Closed samajammin closed 2 years ago

samajammin commented 2 years ago

Noticing we use the getNetworkToken in a few places: https://github.com/ethereum/clrfund/blob/develop/vue-app/src/utils/networks.ts

But in other spots we rely on the currency value of chain info: https://github.com/ethereum/clrfund/blob/develop/vue-app/src/plugins/Web3/constants/chains.ts

samajammin commented 2 years ago

Context / decision related to this, I'm wondering if we should specifically reference Arbitrum ETH as arbETH vs ETH to avoid any potential confusion across the app.

corwintines commented 2 years ago

Since we only use getNetworkToken in one spot (https://github.com/ethereum/clrfund/blob/develop/vue-app/src/api/recipient-registry-optimistic.ts) I propose we just get rid of it in favor of the chain.currency method.