search

ethereum / consensus-spec-tests

Common tests for the Ethereum proof-of-stake consensus layer
MIT License
69 stars 22 forks source link

v1.2.0-rc.1 tests are missing mainnet sync committee update tests #29

Closed michaelsproul closed 1 year ago

michaelsproul commented 2 years ago

The tests previously located at tests/mainnet/altair/epoch_processing/sync_committee_updates are missing from the v1.2.0-rc.1 tarballs

hwwhww commented 1 year ago

Hi @michaelsproul

All the current epoch_processing/sync_committee_updates tests are minimal preset only. However, our test generator created the folder for the mainnet preset by default.

@ralexstokes also found it last month and we updated the test generator runner script to delete the empty folders. Next time there should be no empty folders in the tarballs.

Thanks for the report! 🙏

michaelsproul commented 1 year ago

Awesome, thanks, that makes sense!