Open tbenr opened 1 year ago
good points!
- I'm not sure we need the beacon slot and root in the sidecar gossip anymore because of the simultaneous delivery (especially if we make our range/root requests coupled as well)
Yes, makes sense for the coupled container but if we leave the decoupled "byRange" methods (which was the latest direction if I recall correctly) hey might have more sense
Shouldn't we rely on kzg library verification here by running validate_blobs_sidecar and all the low level KZG\BLS checks will be done internally by the kzg library?
We either need signature or full kzg validation as discussed in https://github.com/ethereum/consensus-specs/issues/3103
I think we can make an argument to remove all the low-level kzg checks in either signature or full kzg validation cases. If the signature can be validated, is it still worth the low-level kzg checks before forwarding it to peers? They are cheap checks, so maybe why not
Current rules:
sidecar.beacon_block_root == block.block.hash_tree_root()
?slot
andblock_root
checks sincesigned_beacon_block_and_blobs_sidecar
itself is inconsistent thus invalid?validate_blobs_sidecar
and all the low level KZG\BLS checks will be done internally by the kzg library?cc @terencechain