ethereum / devp2p

Ethereum peer-to-peer networking specifications
984 stars 275 forks source link

WHOAREYOU sequence number #114

Closed jannikluhn closed 5 years ago

jannikluhn commented 5 years ago

If the handshake recipient does not know any ENR of the initiator, what sequence number should they include in the WHOAREYOU packet? I would assume 0, but this creates a problem if 0 is used as sequence number for new ENRs. I guess the simplest solution is to just start with 1 and perhaps that's the intention, but I couldn't find this being mentioned anywhere.

fjl commented 5 years ago

Yes, they should send zero in this case.