search

ethereum / devp2p

Ethereum peer-to-peer networking specifications
984 stars 275 forks source link

discv5: define ECDH better #116

Closed fjl closed 4 years ago

fjl commented 4 years ago

It would be better to define ECDH agree to match libsecp256k1. This way people can just use the library without worrying about it too much.

The spec should also define the wire format of ephemeral-pubkey.

AgeManning commented 4 years ago

Also, specify the ECDSA algorithm. I was using RFC3278 which is DER-encoded. The go implementation uses r | s (which makes sense in hindsight as it matches ENR sigs).