ethereum / devp2p

Ethereum peer-to-peer networking specifications
979 stars 275 forks source link

discv5: test vectors incorrect #147

Closed decanus closed 4 years ago

decanus commented 4 years ago

In the FindNode test vector we use the distance 256. This number impossible, the max distance due to the fact that we must query with a logarithmic distance is 8. It would probably make sense to use a number which can actually occur.

log2(256) = 8

https://github.com/ethereum/devp2p/blob/master/discv5/discv5-wire-test-vectors.md#findnode-request