search

ethereum / devp2p

Ethereum peer-to-peer networking specifications
979 stars 275 forks source link

discv5: support multi-packet talk. #192

Open SangameswaranRS opened 2 years ago

SangameswaranRS commented 2 years ago

I was thinking that it would be nice for the spec to support multi-packet talks like NODES or so. It would be really useful in designing "custom protocols" over talk. (rendezvous for instance).

Regarding the implementations it should be simple too, so too much effort would not be used up in implementing this change.

Disclaimer: If this is wrong, or doesn't align with eth2 roadmap or so, please feel free to close this without any explanation

fjl commented 2 years ago

Hey, it's always OK to bring up enhancements!

Please provide a bit more detail about the packet types you would like to see.

SangameswaranRS commented 2 years ago

Pretty much the same talk packet type, I was thinking that it would be great to hand out multiple talk responses per talk request, and we'd leave the app level talk handler to decide on whether it needs to send out single or multiple response packets, Depending on the protocol identifier. Protocol may still limit the number of outgoing response packets per request (4 seems like a great number, like Nodes)

I thought that this would be a nice addition because we cannot send much data in a single talk request (1280 constraint on size)

An example scenario: For designing a rendezvous kinda node for fast bootstrapping or traffic optimal bootstrapping for light clients, it would come in handy. Yes, we may still rely on other protocols and get the ENR's externally and dump in our node table.

creaider commented 2 years ago

fucking liare ! Sit @ shatt

SangameswaranRS commented 2 years ago

fucking liare ! Sit @ shatt

what is your problem?