ethereum / devp2p

Ethereum peer-to-peer networking specifications
971 stars 273 forks source link

Error in DiscV4 documentation #194

Closed boukestam closed 2 years ago

boukestam commented 2 years ago

I've going through this documentation for a side project and I think I found an issue in the Node Discovery Protocol docs. In the FindNode section it says the following:

The target is a 65-byte secp256k1 public key.

But after some debugging and testing and looking at the ethereumjs-devp2p repository I found out it's actually supposed to be the 64-byte node id.

fjl commented 2 years ago

Thanks! It's fixed now.