ethereum / devp2p

Ethereum peer-to-peer networking specifications
971 stars 273 forks source link

discv5: additional text around NAT hole punching #231

Open emhane opened 1 year ago

emhane commented 1 year ago

Theory around the actual hole punching: keeping a hole punched, how a node discovers if it is behind a NAT and some on how the handling of holes maintains properties held by the p2p network.

emhane commented 1 year ago

Now, it is ready for review. If you may @fjl .

fjl commented 1 year ago

Right now, it isn't super clear from this text what the implementation requirements are. The text has both descriptions of implementation features and rationale-type content, where you explain 'common situations' and their outcomes.

Please add a section that clearly states the logic that implementations should apply. Specifically, please describe separately the rules for NAT traversal initiator, relay, and recipient.

emhane commented 1 year ago

Right now, it isn't super clear from this text what the implementation requirements are. The text has both descriptions of implementation features and rationale-type content, where you explain 'common situations' and their outcomes.

Please add a section that clearly states the logic that implementations should apply. Specifically, please describe separately the rules for NAT traversal initiator, relay, and recipient.

Ok, done, let me know what you think.