search

ethereum / devp2p

Ethereum peer-to-peer networking specifications
971 stars 273 forks source link

discv5: fix NEIGHBORS -> NODES #252

Closed nalepae closed 4 months ago

nalepae commented 4 months ago

The current version of the spec gives the impression that NEIGHBORS is the response to the FINDNODE request, while NODES is the actual response.

(There is no NEIGHBORS response defined in discv5-wire.md)

fjl commented 4 months ago

Thanks!

nalepae commented 4 months ago

Actually I just noticed that NEIGHBOR was the 0x04 message in discv4.

fjl commented 4 months ago

Yes, it exists in discv4 but not in discv5.

nalepae commented 4 months ago

Yes ;)

Just reading the geth discv5 implementation right now. It seems really clear. Thank you for this!