ethereum / eipw

Mozilla Public License 2.0
28 stars 27 forks source link

EIPW should warn if an otherwise valid EIP file is contained in a folder not named `EIPS` #61

Closed Pandapip1 closed 1 year ago

Pandapip1 commented 1 year ago

See https://github.com/ethereum/EIPs/issues/6172#issuecomment-1364709916

SamWilsn commented 1 year ago

The GitHub Action for eipw only checks files in the EIPS directory (because of the template, markdown in asset folders, etc.) You're suggesting that eipw should check all eip-*.md files regardless of where they are, be silent if they don't pass validation, but warn if they pass validation but aren't in EIPS/?

Pandapip1 commented 1 year ago

You're suggesting that eipw should check all eip-*.md files regardless of where they are, be silent if they don't pass validation, but warn if they pass validation but aren't in EIPS/?

Yes, that's exactly what I'm suggesting.

Pandapip1 commented 1 year ago

Will be implemented in the review bot instead.