search

ethereum / eipw

Mozilla Public License 2.0
27 stars 26 forks source link

Missing `last-call-deadline` should not create an annotation #69

Open Pandapip1 opened 1 year ago

Pandapip1 commented 1 year ago

This is automagically assigned by the review bot now, meaning that a missing last call deadline should block the PR, but shouldn't display an annotation.

SamWilsn commented 1 year ago

Just to confirm what you want here, should eipw return a zero exit code (indicating success) or a non-zero exit code (indicating failure) when last-call-deadline is missing?

Pandapip1 commented 1 year ago

I would like it to fail, but to create either an info-type annotation or no annotation whatsoever.