ethereum / eipw

Mozilla Public License 2.0
27 stars 26 forks source link

Allow links to EIP commits when EIP isn't a dependency #95

Open timbeiko opened 4 months ago

timbeiko commented 4 months ago

Currently, the EIP bot will block an EIP moving from Draft to Review if any EIP linked is in a Draft or Stagnant stage. While this is reasonable for EIPs that are strict dependencies, listed in the requires header field, it feels overly restrictive when applied to EIPs that are simply mentioned as references in the body of an EIP.

For these, we should consider allowing links to specific commits in the EIPs repo, like we do for the EL and CL pyspecs.

Here are recent examples where the current behaviour is problematic:

On that last point, using internal links for requires EIP mentions and external links for other mentions will help readers differentiate between the two when clicking the links.