search

ethereum / ens-registrar-dapp

Registrar DApp for the Ethereum Name Service
MIT License
94 stars 56 forks source link

Allow more characters #113

Open JustinDrake opened 7 years ago

JustinDrake commented 7 years ago

I'd like to register names such as ben&jerry. Unfortunately I get an error. Would it be possible to add more characters such as &, +, $, etc? It may make sense to have emojis as well I❤ether.

screen shot 2017-05-10 at 13 50 01

Arachnid commented 7 years ago

The only valid ASCII characters are [a-z0-9-], just like in DNS domains - so "ben&jerry" will never be allowed.

Unicode is supported, though, so once proper normalisation is implemented in the app, you will be able to use emojis etc.

JustinDrake commented 7 years ago

I don't understand how ben&jerry will never be allow if unicode is supported. These two statements seem contradictory.

Arachnid commented 7 years ago

Unicode is supported, but some unicode codepoints are prohibited, including those ASCII codepoints (<128) that aren't [a-z0-9-]. For full details on what characters are allowed, see UTS 46.