search

ethereum / ens-registrar-dapp

Registrar DApp for the Ethereum Name Service
MIT License
94 stars 56 forks source link

finalization issue #146

Open bdrehmer opened 7 years ago

bdrehmer commented 7 years ago

For this ENS auction (krishnan.ens): https://etherscan.io/enslookup?q=0x34d07f64507d3220a7a755f469c9ca6270f57491fb5a8b61085467d94cb53078

There were 3 bids, with mine being the highest. On the registrar DAPP page, it gets the refund amount upon finalisation correct, but it says that no other bids exceeded the minimum bid amount.

"This name was registered at 2017-05-21. Owner offered to pay up to 0.1 ether. No other bid was above the minimum of 0.01 ether. Owned by: this account belongs to you Needs to be renewed by: 2019-05-21 Before any changes can be done to the name, the owner of this name needs to be finalized which can send them a refund 0.04700000000000001 ether to them."

edit: (sorry this did go through, didn't know you had to look in 'internal transactions') And possibly related, if you look at~ ~~the finalisation transaction, you will see that the refund of the amount over the second highest bid doesn't make it through to the address that won the auction. The ownership of the domain did seem to work properly.

Chromium + MetaMask, Ubuntu 16.04 LTS

While you're looking at this, the wording "which can send them a refund 0.04700000000000001 ether to them." isn't very good. Should just be "which can send them a refund of 0.04700000000000001 ether"

bdrehmer commented 7 years ago

Thinking more about it, I have been having some struggles with my router lately. At the time of finalisation I had some connectivity obviously since the finalisation appears on the blockchain, but maybe intermittent connectivity messed it up somehow? Is there some checking on the state of connectivity? Maybe more of a MetaMask issue if it reports old info instead of some sort of connection error.