search

ethereum / ens-registrar-dapp

Registrar DApp for the Ethereum Name Service
MIT License
94 stars 56 forks source link

TypeError when trying to place bid #193

Closed wjmelements closed 6 years ago

wjmelements commented 6 years ago 
Uncaught TypeError: Cannot read property 'length' of undefined
    at h.TemplateInstance.l.randomName (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:207)
    at h.TemplateInstance.l.createHashesArray (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:207)
    at Object.n (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:207)
    at 51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:107
    at Function.e._withTemplateInstanceFunc (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:107)
    at h.View.<anonymous> (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:107)
    at 51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:106
    at Object.h._withCurrentView (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:106)
    at h._DOMRange.<anonymous> (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:106)
    at HTMLFormElement.<anonymous> (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:106)
wjmelements commented 6 years ago 
Uncaught TypeError: Cannot read property 'length' of undefined
    at h.TemplateInstance.l.randomName (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:207)
    at h.TemplateInstance.l.randomMix (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:207)
    at h.TemplateInstance.l.createHashesArray (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:207)
    at Object.n (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:207)
    at 51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:107
    at Function.e._withTemplateInstanceFunc (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:107)
    at h.View.<anonymous> (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:107)
    at 51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:106
    at Object.h._withCurrentView (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:106)
    at h._DOMRange.<anonymous> (51ec55b8ddb3549fcf31dec0c746493c9aa2b734.js:106)
wjmelements commented 6 years ago

I am unable to bid via http://registrar.ens.domains/ with both Mist and Chrome-MetaMask.

wjmelements commented 6 years ago

launchRatio 3.2100486588541655 and

knownNames.length 1146799

Math.floor(Math.random() * knownNames.length * 3.2100486588541655) usually generates a number larger than knownNames.length.

knownNames[Math.floor(Math.random() knownNames.length 3.2100486588541655)] undefined

wjmelements commented 6 years ago

The simplest fix is to use modulus.

wjmelements commented 6 years ago

https://github.com/ethereum/ens-registrar-dapp/pull/194

wjmelements commented 6 years ago

I am able to work around this issue by repeatedly clicking Bid.

pronobis commented 6 years ago

Same issue.

wjmelements commented 6 years ago

Fixed by https://github.com/ethereum/ens-registrar-dapp/pull/196