search

ethereum / ens-registrar-dapp

Registrar DApp for the Ethereum Name Service
MIT License
94 stars 56 forks source link

fix TypeError preventing bids in the dapp #194

Closed wjmelements closed 6 years ago

wjmelements commented 6 years ago

This fixes #193.

193 prevents bids due to a TypeError. The likelihood that newBid fails appears to increase as time passes. As documented in #193, a launch ratio of 3.2100486588541655 causes randomName to throw a TypeError ~69% of the time.

wjmelements commented 6 years ago

@alexvandesande ptal

wjmelements commented 6 years ago

Closing; this is redundant with https://github.com/ethereum/ens-registrar-dapp/pull/196.

Arachnid commented 6 years ago

Sorry, I didn't see this one! The one I approved didn't include a rebuild - would you be prepared to submit one that does?