search

ethereum / esp-website

Website for the Ethereum Foundation's Ecosystem Support Program (ESP):
https://esp.ethereum.foundation/
MIT License
48 stars 36 forks source link

Add new fields in grantee finance form #365

Closed pettinarip closed 7 months ago

pettinarip commented 7 months ago

Description

Adds new fields in grantee finance form.

Preview: https://deploy-preview-365--ecosystem-support.netlify.app/applicants/grantee-finance

Related Issue

Fixes #360

pettinarip commented 7 months ago

Approving since it fits the requirements asked

I do have a question about validation though.

Wouldn't you want to require a value from either "Which layer 2 network?" or "If the Layer 2 network you would like is not available, please let us know which networks you would like supported, separated by commas" if the user selects yes? Seems like a chance to miss some form information if these are both able to be empty.

Right. Let me see if I can do something here.

pettinarip commented 7 months ago

@corwintines ok, I did a few changes to avoid having empty values in both fields. Now, they are all conditional fields.

If you select "l2 payment" then "l2 network" is a required field. If you select "Other - as l2 network" then "l2 network other" field is required.

This change should prevent having undesired or incomplete data.

wackerow commented 7 months ago

Per issue comment:

image

This was here before, but now I don't see this question anymore:

image

@pettinarip Am I missing something?

pettinarip commented 7 months ago

@wackerow so, I made a change to avoid having empty data.

Now, you will see a "Other" option in the l2 network select field. Once you select that option, you will see the other field that you mentioned.