search

ethereum / eth-abi

Ethereum ABI utilities for python
MIT License
247 stars 269 forks source link

Add API methods to ABIType for web3 #118

Closed davesque closed 5 years ago

davesque commented 5 years ago

What was wrong?

Web3.py still uses the deprecated process_type function which assumes all type strings are terminal types (non-tuple types).

How was it fixed?

This PR adds some API features to the AST classes whose instances are output by eth-abi's new parsing facilities. These new API features can then be utilized in web3.py to remove the old process_type function.

Cute Animal Picture

Cute animal picture

davesque commented 5 years ago

@pipermerriam I suppose this part of eth-abi could maybe use a documentation update. Since we're going to pull it into web3.py, it's starting to look like public API but I don't think there's any section in the docs for it. I'd like to address that in a separate issue ticket if possible so it doesn't block the related web3 work for too long.

pipermerriam commented 5 years ago

I'm fine with docs happening separately but they should happen asap so we don't forget.