search

ethereum / eth-abi

Ethereum ABI utilities for python
MIT License
247 stars 269 forks source link

Update officially supported python versions #124

Closed davesque closed 5 years ago

davesque commented 5 years ago

What was wrong?

Looks like web3.py only tests against python 3.6 and 3.7.

How was it fixed?

Updated testing config to do the same.

Cute Animal Picture

Cute animal picture

davesque commented 5 years ago

Yep, I'll add that.

Wasn't there some talk about dropping pypy support? I dunno. I feel like it's a bit of a hassle to have to remember which packages do or don't support pypy. Seems better to just decide one way or another that we support pypy. Another problem I have with supporting pypy is that it often lags behind the current python sub version by about two versions. That limits the possible use of nice, next gen language features.

davesque commented 5 years ago

So dropping python3.5 support but keeping pypy3 support is really like doing nothing because pypy3 only implements 3.5 last I checked.

carver commented 5 years ago

I feel like it's a bit of a hassle to have to remember which packages do or don't support pypy. Seems better to just decide one way or another that we support pypy.

My logic is that it's much easier to notice that you're adding a pypy-unfriendly library in a failing PR than it is to go re-audit every library and every dependency of every library we maintain.

So dropping python3.5 support but keeping pypy3 support is really like doing nothing because pypy3 only implements 3.5 last I checked.

Argh, okay, fine. I hate py3.5 slightly more than I hate having to go back and make every single library re-support pypy3 someday.

davesque commented 5 years ago

Hehe, yay! 🎉