search

ethereum / eth-abi

Ethereum ABI utilities for python
MIT License
247 stars 269 forks source link

use self reference rather than super #139

Closed JoranHonig closed 4 years ago

JoranHonig commented 4 years ago

This change aligns the use of seek with the use in pop_frame Additionally, inheritants can now override the behaviour of the seek call in seek_in_frame(...)

What was wrong?

The call to seek in seek_in_frame() was using super() to get a reference to the function seek().

How was it fixed?

super() -> self

Cute Animal Picture

Cute animal picture

JoranHonig commented 4 years ago

@the reviewer of this pr I thought about opening an issue for this change, but it was easier to just submit a PR right away.

Let me know if you would like a larger ratification for the change!

carver commented 4 years ago

@the reviewer of this pr

Poor Thomas Eichmann probably gets this a lot :laughing:

I thought about opening an issue for this change, but it was easier to just submit a PR right away.

Thanks for the PR!

LGTM. I think this was a little oversight on my part.

Yup, LGTM, too. Thanks for taking a look @davesque

carver commented 4 years ago

@JoranHonig sorry it took a while to get this out. Thanks for the contribution! It's available in v2.1.1