ethereum / eth-abi

Ethereum ABI utilities for python
MIT License
241 stars 268 forks source link

Padding of empty `bytes` #151

Closed numpde closed 2 years ago

numpde commented 2 years ago

What is the reason for padding with 32 zeros here for an empty bytes array? https://github.com/ethereum/eth-abi/blob/decaadcdf7a33020846aafd9ba36859c1ab82909/eth_abi/encoding.py#L535

I think it's different from what happens here, namely no padding https://github.com/ethereumjs/ethereumjs-abi/blob/ee3994657fa7a427238e6ba92a84d0b529bbcde0/lib/index.js#L146

I know the latter is deprecated but it seems this is how it is done by the opensea.io frontend.

Are both correct but according to different standards/versions?

Thank you.