Closed charles-cooper closed 2 years ago
@kclowes @fselmo is it possible to get a review on this? I can fix the merge conflicts if the approach looks ok
Thanks for the ping, @charles-cooper. This change looks fine to me. If you don't mind fixing the merge conflicts I can probably get this in next week. Thanks!
edit: if you don't hear from me next week, feel free to tag me again :)
@kclowes resolved!
i see that this breaks some specific tests:
@kclowes actually i think it would be good to remove the abbr()
function altogether? it's not friendly for debugging, and as downstream tools (like pytest) have settings to truncate output anyways -- i can't really think of a situation where you want to truncate the info in the exception which isn't already handled by downstream tooling
Yeah, that's a fair point. I just changed the expectation of the tests for now. I think it does make sense to remove abbr
in the next major release. What version of eth-abi
are you using?
Yeah, that's a fair point. I just changed the expectation of the tests for now. I think it does make sense to remove
abbr
in the next major release. What version ofeth-abi
are you using?
2.1.1 and 3.0.0
2.1.1 and 3.0.0
Cool. I'll try and get those released next week. Thanks again!
Thanks @kclowes !!
@charles-cooper both 2.2.0 and 3.0.1 are out with this fix!
allow more int values to be fully printed in errors. the current code truncates a lot of integer values which fit in 256 bits, which reduces helpfulness of the error message when debugging.
What was wrong?
Issue #
How was it fixed?
Summary of approach.
To-Do
[ ] Clean up commit history
[x] Add entry to the release notes
Cute Animal Picture
![put a cute animal picture link inside the parentheses]()