Closed jad-elmourad closed 1 year ago
@fselmo Thanks for your comments. I think that's a good approach. Feel free to push the commits you mentioned in #198
@jad-elmourad, pushed up 👍🏼. Let me know if you see anything that needs attention.
@pacrob + @reedsa, this is ready for a review. See the linked issue for a bit more context.
Looks good to me too!
What was wrong?
closes #198
How was it fixed?
@jad-elmourad:
@fselmo:
Introduce this as a feature by allowing the default "strict mode" behavior for the
BytesStringDecoder
to be turned off via astrict
flag that isTrue
by default. The current behavior of the library isstrict=True
so this shouldn't be a breaking change. Whenstrict=False
, the behavior desired in #198 is enabled.Add some testing around this and make sure all other decoding tests pass whether the
strict
flag isTrue
orFalse
.Cute Animal Picture