ethereum / eth-abi

Ethereum ABI utilities for python
MIT License
240 stars 268 forks source link

Upgrade template #217

Closed pacrob closed 9 months ago

pacrob commented 9 months ago

What was wrong?

Merge changes from the project template, notably:

Closes #207

eth-abi previously only had typing for the eth_abi/utils folder. This PR adds typing for the eth_abi/tools folder, and adds the remaining files as a list to be excluded from mypy in .pre-commit-config.yaml As typing is added to individual files, those can be removed from the exclude list.

Todo:

Cute Animal Picture

image

fjarri commented 7 months ago

It seems that this PR deleted py.typed in the main eth_abi directory, thus breaking type checking in dependencies. Was that intentional?

pacrob commented 7 months ago

@fjarri Sorry about that. I had moved the py.typed to the tools and utils folders because they were fully typed, while the eth_abi/*.py files only have minimal typing. I didn't think about the downstream breaking. I'll get that back in there.

fjarri commented 7 months ago

No problem, just wanted to make sure it wasn't accidental. Technically the change appeared in v5.0 so API breakage is expected. I have no problem with doing some explicit cast() until py.typed can be returned.