ethereum / eth-abi

Ethereum ABI utilities for python
MIT License
248 stars 269 forks source link

Upgrade `parsimonious` to `0.10` #231

Closed jorenham closed 8 months ago

jorenham commented 8 months ago

What was wrong?

The parsimonious dep was pinned to an outdated version.

The 0.10.0 release includes bugfixes and performance improvements, see https://github.com/erikrose/parsimonious?tab=readme-ov-file#version-history.

The breaking change that's mentioned shouldn't affect the grammar that's used here, as it used spaces where relevant.

How was it fixed?

Sheer willpower.

Todo:

Cute Animal Picture

The shoebill

The shoebill (Balaeniceps rex), also known as the whalebill, whale-headed stork, and shoe-billed stork is a large long-legged wading bird.

[Wikipedia - Shoebill]

jorenham commented 8 months ago

I noticed that the newsfragments directory is empty. Should I create a newsfragment there nonetheless, or edit the release notes directly, or ...?

pacrob commented 8 months ago

I noticed that the newsfragments directory is empty. Should I create a newsfragment there nonetheless, or edit the release notes directly, or ...?

There's usage info in the README within the newsfragments directory. For this PR, I'd use the filename 231.internal.rst. The files are then collected and processed into release notes at the next release.

pacrob commented 8 months ago

looks good, thanks @jorenham !