search

ethereum / eth-account

Account abstraction library for web3.py
http://eth-account.readthedocs.io/
MIT License
269 stars 156 forks source link

bump version limits for bitarray dependency #161

Closed oberstet closed 2 years ago

oberstet commented 2 years ago

fixes https://github.com/ethereum/eth-account/issues/160

carver commented 2 years ago

Bumping this is a breaking change by our semver rules. If we left the lower limit and increase only the upper limit, then I expect it to be fine. Already installed copies should keep working fine, and newly installed copies will grab the latest available.

carver commented 2 years ago

Ah, looks like this is already covered by #159 -- although I think you're right that the upper limit should just be v3

I'm going to close it as a duplicate, though

oberstet commented 2 years ago

ok, sounds good! thanks!

Bumping this is a breaking change by our semver rules. If we left the lower limit and increase only the upper limit

fwiw, in general, any upper limit is a pain. I have spent quite some hours because of a diamond shaped dependency graph with the same library being a dependency via two intermediary nodes, merging in a single app as tree root. if the dependency is required in different upper versions in the intermediary nodes in the dependency graph, pip will usually go into infinite looping to figure out a resolved tree. The solution then is to manually figure out a working version, pin that version in requirements of the app, so that pip will be forced to use that version. even figuring out that pip behavior took me many hours. IOW: pls try to avoid any upper limits;) my 2cts.